-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add review comment to sb files #68409
Conversation
Rather than comments, please update the CODEOWNERS file to include the relevant files and the source build team, so that it automatically includes you on such PRs. |
Initially wanted to add both the comment and the If you are OK with granting write permissions to |
@333fred soft ping - would write access to the team be considered as an option or can we move on with merging this PR as is? Thank you! |
@oleksandr-didyk write access for dotnet/source-build-internal has been added. |
ec738ba
to
fb5d56f
Compare
Thank you! Added the |
Contributes to dotnet/source-build#3435
Adds comments to source-build files asking for the inclusion of the source-build team in PRs that alter
SourceBuild*
files. Non-reviewed changes could potentially cause issues down the line, be it in the downstream repos or the product build (as has happened in the past, see dotnet/source-build#3435 (comment))